From ce34ca8f1fe41e1f11517168394172aafae16a2b Mon Sep 17 00:00:00 2001 From: Nicolas Luck Date: Fri, 9 Feb 2024 13:48:45 +0100 Subject: [PATCH] continue-on-error if target=wasm32 or rust=nightly --- .github/workflows/ci.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 875aedab..b992191f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,8 +48,7 @@ jobs: # rust versions - { os: ubuntu-22.04, rust-version: "1.70", target: 'x86_64-unknown-linux-gnu'} - { os: ubuntu-22.04, rust-version: beta, target: 'x86_64-unknown-linux-gnu'} - - { os: ubuntu-22.04, rust-version: nightly, target: 'x86_64-unknown-linux-gnu', continue-on-error: true} - continue-on-error: ${{ matrix.continue-on-error }} + - { os: ubuntu-22.04, rust-version: nightly, target: 'x86_64-unknown-linux-gnu'} defaults: run: shell: bash @@ -64,10 +63,10 @@ jobs: # Build and test. - name: Build library - continue-on-error: ${{ contains(matrix.target,'wasm32') }} # allow wasm builds to fail tests for now + continue-on-error: ${{ contains(matrix.target,'wasm32') || contains(matrix.rust-version,'nightly') }} # allow wasm builds to fail tests for now run: cargo build --all-targets --target ${{ matrix.target }} ${{ matrix.args }} --verbose - name: Test - continue-on-error: ${{ contains(matrix.target,'wasm32') }} # allow wasm builds to fail tests for now + continue-on-error: ${{ contains(matrix.target,'wasm32') || contains(matrix.rust-version,'nightly') }} # allow wasm builds to fail tests for now run: cargo test --target ${{ matrix.target }} ${{ matrix.args }} --all # On stable rust builds, build a binary and publish as a github actions -- 2.54.0