From: Mark Thom <markjordanthom@gmail.com>
Date: Mon, 22 Mar 2021 22:53:23 +0000 (-0600)
Subject: flush loader term queue before compiling declarations, declare '/1' as dynamic before... 
X-Git-Tag: v0.9.0~110
X-Git-Url: https://git.sagredo.dev/?a=commitdiff_plain;h=fffb87d0135a0cf49a456848bc5a708c0ee67a0f;p=scryer-prolog.git

flush loader term queue before compiling declarations, declare '/1' as dynamic before asserting
---

diff --git a/src/lib/builtins.pl b/src/lib/builtins.pl
index 4be59979..16d842bb 100644
--- a/src/lib/builtins.pl
+++ b/src/lib/builtins.pl
@@ -839,9 +839,9 @@ asserta_clause(Head, Body) :-
 	     arg(2, Head, F),
 	     module_asserta_clause(F, Body, Module)
        ; '$head_is_dynamic'(user, Head) ->
-         call_asserta(Head, Body, Name, Arity, user)
+          call_asserta(Head, Body, Name, Arity, user)
        ; '$no_such_predicate'(user, Head) ->
-         call_asserta(Head, Body, Name, Arity, user)
+          call_asserta(Head, Body, Name, Arity, user)
        ;  throw(error(permission_error(modify, static_procedure, Name/Arity), asserta/1))
        )
     ;  throw(error(type_error(callable, Head), asserta/1))
diff --git a/src/loader.pl b/src/loader.pl
index a748f981..3e2a7b9b 100644
--- a/src/loader.pl
+++ b/src/loader.pl
@@ -91,6 +91,7 @@ run_initialization_goals :-
     prolog_load_context(module, Module),
     (  predicate_property(Module:'$initialization_goals'(_), dynamic) ->
        findall(Goal, '$call'(builtins:retract(Module:'$initialization_goals'(Goal))), Goals),
+       abolish(Module:'$initialization_goals'/1),
        (  maplist(Module:call, Goals) ->
           true
        ;  true %% initialization goals can fail without thwarting the load.
@@ -275,7 +276,7 @@ compile_dispatch_or_clause(Term, Evacuable) :-
     (  var(Term) ->
        instantiation_error(load/1)
     ;  compile_dispatch(Term, Evacuable) ->
-       true
+       '$flush_term_queue'(Evacuable)
     ;  compile_clause(Term, Evacuable)
     ).
 
@@ -364,6 +365,7 @@ compile_declaration(discontiguous(Module:Name/Arity), Evacuable) :-
     '$add_discontiguous_predicate'(Module, Name, Arity, Evacuable).
 compile_declaration(initialization(Goal), Evacuable) :-
     prolog_load_context(module, Module),
+    '$add_dynamic_predicate'(Module, '$initialization_goals', 1, Evacuable),
     assertz(Module:'$initialization_goals'(Goal)).
 compile_declaration(set_prolog_flag(Flag, Value), _) :-
     set_prolog_flag(Flag, Value).
diff --git a/src/machine/system_calls.rs b/src/machine/system_calls.rs
index a956577e..33cff953 100644
--- a/src/machine/system_calls.rs
+++ b/src/machine/system_calls.rs
@@ -3471,14 +3471,23 @@ impl MachineState {
                 self.fail = match self.store(self.deref(self[temp_v!(2)])) {
                     Addr::Str(s) => match &self.heap[s] {
                         &HeapCellValue::NamedStr(arity, ref name, ref spec) => {
-                            CLAUSE_TYPE_FORMS.borrow().get(&(name.as_str(), arity)).is_some() ||
-                                indices.get_predicate_code_index(
-                                name.clone(),
-                                arity,
-                                module_name,
-                                spec.clone(),
-                            )
-                            .is_some()
+                            if CLAUSE_TYPE_FORMS.borrow().get(&(name.as_str(), arity)).is_some() {
+                                true
+                            } else {
+                                let index = indices.get_predicate_code_index(
+                                    name.clone(),
+                                    arity,
+                                    module_name,
+                                    spec.clone(),
+                                )
+                                .map(|index| index.get())
+                                .unwrap_or(IndexPtr::DynamicUndefined);
+
+                                match index {
+                                    IndexPtr::DynamicUndefined => false,
+                                    _ => true,
+                                }
+                            }
                         }
                         _ => {
                             unreachable!()
@@ -3489,9 +3498,23 @@ impl MachineState {
                             let spec =
                                 fetch_atom_op_spec(name.clone(), spec.clone(), &indices.op_dir);
 
-                            CLAUSE_TYPE_FORMS.borrow().get(&(name.as_str(), 0)).is_some() ||
-                            indices.get_predicate_code_index(name.clone(), 0, module_name, spec)
-                                .is_some()
+                            if CLAUSE_TYPE_FORMS.borrow().get(&(name.as_str(), 0)).is_some() {
+                                true
+                            } else {
+                                let index = indices.get_predicate_code_index(
+                                    name.clone(),
+                                    0,
+                                    module_name,
+                                    spec.clone(),
+                                )
+                                .map(|index| index.get())
+                                .unwrap_or(IndexPtr::DynamicUndefined);
+
+                                match index {
+                                    IndexPtr::DynamicUndefined => false,
+                                    _ => true,
+                                }
+                            }
                         } else {
                             unreachable!()
                         }