From: Markus Triska <triska@metalevel.at>
Date: Thu, 24 Apr 2025 16:19:05 +0000 (+0200)
Subject: ENHANCED: use a fast test for the expected case of chars in atom_chars/2 etc.
X-Git-Tag: v0.10.0~35^2~24
X-Git-Url: https://git.sagredo.dev/?a=commitdiff_plain;h=e9bb41f0d69e0fbaa848ff3a25d9d2dd04a80487;p=scryer-prolog.git

ENHANCED: use a fast test for the expected case of chars in atom_chars/2 etc.

Suggested by Oleg Finkelstein, thank you a lot!

Example, before this change:

    ?- t+\(length(As, 1_000_000), maplist(=(a), As), time(atom_chars(A, As))).
       % CPU time: 0.693s, 7_000_041 inferences
       true.

Now:

    ?- t+\(length(As, 1_000_000), maplist(=(a), As), time(atom_chars(A, As))).
       % CPU time: 0.080s, 40 inferences
       true.

This also partially ameliorates #2907.
---

diff --git a/src/lib/builtins.pl b/src/lib/builtins.pl
index ca07e0c6..df7696f9 100644
--- a/src/lib/builtins.pl
+++ b/src/lib/builtins.pl
@@ -1719,20 +1719,27 @@ must_be_number(N, PI) :-
     ).
 
 
-chars_or_vars(Cs, _) :-
+chars_or_vars(Cs, PI) :-
+    (  '$is_partial_string'(Cs) ->
+       % use a fast test for the expected case
+       true
+    ;  chars_or_vars_(Cs, PI)
+    ).
+
+chars_or_vars_(Cs, _) :-
     (  var(Cs) ->
        !
     ;  Cs == [] ->
        !
     ).
-chars_or_vars([C|Cs], PI) :-
+chars_or_vars_([C|Cs], PI) :-
     (  nonvar(C) ->
        (  atom(C),
           atom_length(C, 1) ->
           chars_or_vars(Cs, PI)
        ;  throw(error(type_error(character, C), PI))
        )
-    ;  chars_or_vars(Cs, PI)
+    ;  chars_or_vars_(Cs, PI)
     ).