From: Mark Thom <markjordanthom@gmail.com>
Date: Thu, 23 Dec 2021 20:31:49 +0000 (-0700)
Subject: create read_term/3 variable lists in order of variable occurrence within terms
X-Git-Tag: v0.9.0~3^2
X-Git-Url: https://git.sagredo.dev/?a=commitdiff_plain;h=9d06229cba7389c52910d140690a82503839d618;p=scryer-prolog.git

create read_term/3 variable lists in order of variable occurrence within terms
---

diff --git a/src/machine/machine_state.rs b/src/machine/machine_state.rs
index d4981852..9e845f04 100644
--- a/src/machine/machine_state.rs
+++ b/src/machine/machine_state.rs
@@ -415,21 +415,12 @@ impl MachineState {
                         return Ok(());
                     }
 
-                    let list_of_var_eqs = push_var_eq_functors(
-                        &mut self.heap,
-                        term_write_result.var_dict.iter(),
-                        &indices.op_dir,
-                        self.atom_tbl.clone(),
-                    );
-
                     let mut singleton_var_set: IndexMap<Ref, bool> = IndexMap::new();
-                    let mut var_list = vec![];
 
                     for addr in self.acyclic_pre_order_iter(term) {
                         if let Some(var) = addr.as_var() {
                             if !singleton_var_set.contains_key(&var) {
                                 singleton_var_set.insert(var, true);
-                                var_list.push(addr);
                             } else {
                                 singleton_var_set.insert(var, false);
                             }
@@ -449,9 +440,28 @@ impl MachineState {
                         self.atom_tbl.clone(),
                     );
 
+                    let mut var_list = Vec::with_capacity(singleton_var_set.len());
+
+                    for (var_name, addr) in term_write_result.var_dict {
+                        if let Some(var) = addr.as_var() {
+                            let idx = singleton_var_set.get_index_of(&var).unwrap();
+                            var_list.push((var_name, addr, idx));
+                        }
+                    }
+
+                    var_list.sort_by(|(_,_,idx_1),(_,_,idx_2)| idx_1.cmp(idx_2));
+
+                    let list_of_var_eqs = push_var_eq_functors(
+                        &mut self.heap,
+                        var_list.iter().map(|(var_name, var,_)| (var_name,var)),
+                        &indices.op_dir,
+                        self.atom_tbl.clone(),
+                    );
+
                     let singleton_addr = self[temp_v!(3)];
-                    let singletons_offset =
-                        Addr::HeapCell(self.heap.to_list(singleton_var_list.into_iter()));
+                    let singletons_offset = Addr::HeapCell(self.heap.to_list(
+                        singleton_var_list.into_iter()
+                    ));
 
                     (self.unify_fn)(self, singletons_offset, singleton_addr);
 
@@ -460,7 +470,9 @@ impl MachineState {
                     }
 
                     let vars_addr = self[temp_v!(4)];
-                    let vars_offset = Addr::HeapCell(self.heap.to_list(var_list.into_iter()));
+                    let vars_offset = Addr::HeapCell(self.heap.to_list(
+                        var_list.into_iter().map(|(_,var,_)| var)
+                    ));
 
                     (self.unify_fn)(self, vars_offset, vars_addr);