From: notoria <notoria@users.noreply.github.com>
Date: Sat, 27 May 2023 11:19:19 +0000 (+0200)
Subject: Don't add variable
X-Git-Tag: v0.9.2~123^2~13
X-Git-Url: https://git.sagredo.dev/?a=commitdiff_plain;h=770a682d8bb6b660f31f1b1c8b6426b609b13489;p=scryer-prolog.git

Don't add variable

?- Z #= 0, Z #= X mod Y.
   Z = 0, clpz:(_A*Y#=X), clpz:(Y in inf.. -1\/1..sup) % Unexpected.

The expected result:
   Z = 0, clpz:(X mod Y#=0), clpz:(Y in inf.. -1\/1..sup).
---

diff --git a/src/lib/clpz.pl b/src/lib/clpz.pl
index 43b8f26e..4cdcdc9a 100644
--- a/src/lib/clpz.pl
+++ b/src/lib/clpz.pl
@@ -5019,8 +5019,6 @@ run_propagator(pmod(X,Y,Z), MState) -->
                 % queue_goal(X #=< XMax)
             ;   true
             )
-            % kill(MState),
-            % queue_goal(X #= Z + Y * _) % Add a variable to be efficient.
         ;   nonvar(Z), nonvar(X) ->
             (   Z > 0 ->
                 (   X < 0 -> true
@@ -5180,7 +5178,7 @@ run_propagator(pmodz(X,Y,Z), MState) -->
             )
         ).
 
-run_propagator(pmody(X,Y,Z), MState) -->
+run_propagator(pmody(_X,Y,Z), _MState) -->
         (   nonvar(Y) -> true % Nothing to do.
         % ;   nonvar(X) -> true
         ;   nonvar(Z) ->
@@ -5196,7 +5194,7 @@ run_propagator(pmody(X,Y,Z), MState) -->
                   domain_remove_greater_than(YD, YMax, YD1) },
                 fd_put(Y, YD1, YPs)
                 % queue_goal(Y #< Z)
-            ;   Z =:= 0 -> kill(MState), queue_goal(X / Y #= _)
+            ;   Z =:= 0 % Multiple solutions so do nothing special.
             )
         ;   (   { fd_get(Z, _, n(ZL), _, _), ZL > 0 } ->
                 { fd_get(Y, YD, YPs),