From: Mark <markjordanthom@gmail.com>
Date: Tue, 24 Oct 2023 20:20:26 +0000 (-0600)
Subject: correct modulus bug (#2118, #2119)
X-Git-Tag: remove~9
X-Git-Url: https://git.sagredo.dev/?a=commitdiff_plain;h=63cbeb9a3cba7fbc9de15390b76e24b1285e104c;p=scryer-prolog.git

correct modulus bug (#2118, #2119)
---

diff --git a/src/machine/arithmetic_ops.rs b/src/machine/arithmetic_ops.rs
index d1f764d6..92e9c599 100644
--- a/src/machine/arithmetic_ops.rs
+++ b/src/machine/arithmetic_ops.rs
@@ -850,15 +850,9 @@ pub(crate) fn modulus(x: Number, y: Number, arena: &mut Arena) -> Result<Number,
     };
 
     fn ibig_rem_floor(n1: &Integer, n2: &Integer) -> Integer {
-        if n1 > &Integer::ZERO && n2 < &Integer::ZERO {
-            ((n1 - Integer::ONE) / n2) - Integer::ONE
-        } else if n1 < &Integer::ZERO && n2 > &Integer::ZERO {
-            ((n1 + Integer::ONE) / n2) - Integer::ONE
-        } else {
-            let ring = ConstDivisor::new(n2.unsigned_abs());
-            let n1 = n1.clone();
-            IBig::from(ring.reduce(n1).residue())
-        }
+        let ring = ConstDivisor::new(n2.unsigned_abs());
+        let n1 = n1.clone();
+        IBig::from(ring.reduce(n1).residue())
     }
 
     match (x, y) {