Document run_module_predicate and handle critical failure in toplevel.pl

diff --git a/src/machine/mod.rs b/src/machine/mod.rs
index bfa4f7b0599042251d3e6fc7c34c7cc600dac388..9a6c50d7509707d120699b1820bf6ad5b90e4cdb 100644 (file)
--- a/src/machine/mod.rs
+++ b/src/machine/mod.rs
@@ -271,6 +271,11 @@ impl Machine {
             .unwrap()
     }
 
+    /// Runs the predicate `key` in `module_name` until completion.
+    /// Siltently ignores failure, thrown errors and choice points.
+    ///
+    /// Consider using [`Machine::run_query`] if you wish to handle
+    /// predicates that may fail, leave a choice point or throw.
     pub(crate) fn run_module_predicate(
         &mut self,
         module_name: Atom,
@@ -279,6 +284,7 @@ impl Machine {
         if let Some(module) = self.indices.modules.get(&module_name) {
             if let Some(code_index) = module.code_dir.get(&key) {
                 let p = code_index.local().unwrap();
+                // Leave a halting choice point to backtrack to in case the predicate fails or throws.
                 self.allocate_stub_choice_point();
 
                 self.machine_st.cp = BREAK_FROM_DISPATCH_LOOP_LOC;

diff --git a/src/toplevel.pl b/src/toplevel.pl
index b43ac3cb5dcb883754f2befed5d766224f5aa4c2..0727aee030da419fa59ccc8767610c46bddf029c 100644 (file)
--- a/src/toplevel.pl
+++ b/src/toplevel.pl
@@ -29,6 +29,19 @@ load_scryerrc :-
     ).
 
 '$repl' :-
+    catch(
+        start_repl,
+        _,
+        % Something bad enough happened that the REPL itself threw an error.
+        % This can be caused by a broken user_output stream, so we cannot
+        % print an error.
+        %
+        % The best we can do now is halt with an error code,
+        % so that users can try to diagnose the issue:
+        halt(99)
+    ).
+
+start_repl :-
     asserta('$toplevel':started),
     raw_argv(Args0),
     (   append(Args1, ["--"|_], Args0) ->