fix unecessary reference/dereference

diff --git a/src/atom_table.rs b/src/atom_table.rs
index 12910753718da479dac738df125c7b0547f39578..d7796d732e5931508e015c14ea2afa356d14d436 100644 (file)
--- a/src/atom_table.rs
+++ b/src/atom_table.rs
@@ -254,7 +254,7 @@ impl std::ops::Deref for AtomString<'_> {
     fn deref(&self) -> &Self::Target {
         match self {
             Self::Static(reference) => reference,
-            Self::Inlined(inlined) => inlined_to_str(&inlined),
+            Self::Inlined(inlined) => inlined_to_str(inlined),
             Self::Dynamic(guard) => guard.deref(),
         }
     }

diff --git a/src/forms.rs b/src/forms.rs
index 409da51ee21b6ffa85966d43d9200e2ec55bc576..26f37b3e9871211cd9f0ed7b1f7c96b09fff2877 100644 (file)
--- a/src/forms.rs
+++ b/src/forms.rs
@@ -372,11 +372,11 @@ pub enum ModuleSource {
 
 impl ModuleSource {
     pub(crate) fn as_functor_stub(&self) -> MachineStub {
-        match self {
-            &ModuleSource::Library(name) => {
+        match *self {
+            ModuleSource::Library(name) => {
                 functor!(atom!("library"), [atom_as_cell(name)])
             }
-            &ModuleSource::File(name) => {
+            ModuleSource::File(name) => {
                 functor!(name)
             }
         }

diff --git a/src/iterators.rs b/src/iterators.rs
index 5bd51d9949f39bd91bcca38366b71419bcc5850e..8e2e43ddee8ab7cce0d5d94dc670c750228672bf 100644 (file)
--- a/src/iterators.rs
+++ b/src/iterators.rs
@@ -403,7 +403,7 @@ impl<'a> Iterator for ClauseIterator<'a> {
                             self.state_stack
                                 .push(ClauseIteratorState::RemainingBranches(branches, 0));
                         }
-                        &ChunkedTerms::Chunk { ref terms } => {
+                        ChunkedTerms::Chunk { ref terms } => {
                             return Some(ClauseItem::Chunk { terms });
                         }
                     }

diff --git a/src/machine/dispatch.rs b/src/machine/dispatch.rs
index 2428f7d2e7b982ae002980edf95beb67e1a41879..af34bcd71a9f44eeaec04c15eea9fe88a435271e 100644 (file)
--- a/src/machine/dispatch.rs
+++ b/src/machine/dispatch.rs
@@ -3277,7 +3277,7 @@ impl Machine {
                     &Instruction::PutPartialString(_, ref string, reg) => {
                         self.machine_st[reg] = backtrack_on_resource_error!(
                             self.machine_st,
-                            self.machine_st.heap.allocate_pstr(&string)
+                            self.machine_st.heap.allocate_pstr(string)
                         );
 
                         self.machine_st.p += 1;

diff --git a/src/machine/heap.rs b/src/machine/heap.rs
index fdf24047a12c226f743095e1042175d765201b0e..66e511f5adb42b156c3bb3dc33e9c112d1a5b1d1 100644 (file)
--- a/src/machine/heap.rs
+++ b/src/machine/heap.rs
@@ -1009,7 +1009,7 @@ impl<'a> PStrSegmentIter<'a> {
         let string_buf = unsafe {
             let char_ptr = heap.inner.ptr.add(pstr_loc);
             let slice = std::slice::from_raw_parts(char_ptr, heap.inner.byte_len - pstr_loc);
-            std::str::from_utf8_unchecked(&slice)
+            std::str::from_utf8_unchecked(slice)
         };
 
         PStrSegmentIter { string_buf }

diff --git a/src/machine/system_calls.rs b/src/machine/system_calls.rs
index 244d56afe05b216fc7729897e0189883ef092c82..ac09b7f81f17d163cc9d22706b3ec550d2fa620d 100644 (file)
--- a/src/machine/system_calls.rs
+++ b/src/machine/system_calls.rs
@@ -2327,7 +2327,7 @@ impl Machine {
 
                 let cell = step_or_resource_error!(
                     self.machine_st,
-                    self.machine_st.heap.allocate_cstr(&*name.as_str())
+                    self.machine_st.heap.allocate_cstr(&name.as_str())
                 );
 
                 unify!(self.machine_st, self.machine_st.registers[2], cell);
@@ -2386,7 +2386,7 @@ impl Machine {
                     self.machine_st,
                     sized_iter_to_heap_list(
                         &mut self.machine_st.heap,
-                        (&*name).chars().count(),
+                        name.chars().count(),
                         iter,
                     )
                 );
@@ -7637,7 +7637,7 @@ impl Machine {
 
         let buffer = git_version!(cargo_prefix = "cargo:", fallback = "unknown");
         let cstr_cell =
-            step_or_resource_error!(self.machine_st, self.machine_st.heap.allocate_cstr(&buffer));
+            step_or_resource_error!(self.machine_st, self.machine_st.heap.allocate_cstr(buffer));
 
         unify!(self.machine_st, cstr_cell, self.machine_st.registers[1]);
     }
@@ -8719,7 +8719,7 @@ impl Machine {
                 Ok(result)
             }
             scraper::Node::Comment(comment) => {
-                let comment = self.machine_st.heap.allocate_cstr(&comment)?;
+                let comment = self.machine_st.heap.allocate_cstr(comment)?;
 
                 let result = str_loc_as_cell!(self.machine_st.heap.cell_len());
                 let mut writer = self.machine_st.heap.reserve(2)?;

diff --git a/src/machine/unify.rs b/src/machine/unify.rs
index 6ada6fb1c904661462f0b151cb9abb12f334a607..fdc430eeb059d27567422ea9f8371944d277c54b 100644 (file)
--- a/src/machine/unify.rs
+++ b/src/machine/unify.rs
@@ -290,7 +290,7 @@ pub(crate) trait Unifier: DerefMut<Target = MachineState> {
                 let machine_st = self.deref_mut();
 
                 let f1 = machine_st.arena.f64_tbl.get_entry(f1);
-                let f2 = machine_st.arena.f64_tbl.get_entry(f2.into());
+                let f2 = machine_st.arena.f64_tbl.get_entry(f2);
 
                 self.fail = f1 != f2;
             }

diff --git a/src/parser/ast.rs b/src/parser/ast.rs
index 654b290131f4788989d75eae0b264ed4967be150..da9353ecf8bb771d5128c2499ade8920f4554665 100644 (file)
--- a/src/parser/ast.rs
+++ b/src/parser/ast.rs
@@ -858,9 +858,9 @@ impl Term {
     }
 
     pub fn name(&self) -> Option<Atom> {
-        match self {
-            &Term::Literal(_, Literal::Atom(atom)) => Some(atom),
-            &Term::Clause(_, atom, ..) => Some(atom),
+        match *self {
+            Term::Literal(_, Literal::Atom(atom)) => Some(atom),
+            Term::Clause(_, atom, ..) => Some(atom),
             _ => None,
         }
     }

diff --git a/src/parser/parser.rs b/src/parser/parser.rs
index 7a8895206fb039d7e2baa7eb91332a49d556e8b9..a874face7507aa751249db02cdd1de2ddddcef1b 100644 (file)
--- a/src/parser/parser.rs
+++ b/src/parser/parser.rs
@@ -111,7 +111,7 @@ pub(crate) fn as_partial_string(
                 tail_ref = tail;
             }
             Term::CompleteString(_, cstr) => {
-                string += &*cstr.as_str();
+                string += cstr.as_str();
                 tail = Term::Literal(Cell::default(), Literal::Atom(atom!("[]")));
                 break;
             }