add failing test highlighting panic on invalid UTF-8 cstr

Signed-off-by: Thierry Marianne <[email protected]>

diff --git a/tests-pl/ffi_utf8_panic.pl b/tests-pl/ffi_utf8_panic.pl
new file mode 100644 (file)
index 0000000..2ca32ce
--- /dev/null
+++ b/tests-pl/ffi_utf8_panic.pl
@@ -0,0 +1,16 @@
+:- use_module(library(os)).
+:- use_module(library(ffi)).
+
+init :-
+    read(Body),
+    term_variables(Body, [LIB]),
+    Body,
+    use_foreign_module(LIB, [
+        'ffi_invalid_utf8_cstr'([], cstr)
+    ]).
+
+test :-
+    ffi:'ffi_invalid_utf8_cstr'(Str),
+    write(Str), nl.
+
+:- initialization((init,test)).

diff --git a/tests/scryer/issues.rs b/tests/scryer/issues.rs
index cb32174647fbada3682f1fc6ddf1d8ae6a44e63e..856da766f53e59b011916112e3b085f0d743a236 100644 (file)
--- a/tests/scryer/issues.rs
+++ b/tests/scryer/issues.rs
@@ -150,3 +150,50 @@ fn http_open_hanging() {
             "received response with status code:200\nreceived response with status code:200\nreceived response with status code:200\nreceived response with status code:200\nreceived response with status code:200\n"
     );
 }
+
+#[test]
+#[cfg_attr(miri, ignore = "ffi")]
+fn ffi_utf8_panic() {
+    let tmp_dir: &std::path::Path = env!("CARGO_TARGET_TMPDIR").as_ref();
+    let name = "ffi_utf8_panic";
+    let src = r##"
+        #[unsafe(no_mangle)]
+        extern "C" fn ffi_invalid_utf8_cstr() -> *const core::ffi::c_char {
+            b"Invalid\xFFUTF8\x00".as_ptr() as *const _
+        }
+    "##;
+
+    let mut child = std::process::Command::new("rustc")
+        .stdin(std::process::Stdio::piped())
+        .args(["--edition", "2024"])
+        .arg(format!("--target={}", current_platform::CURRENT_PLATFORM))
+        .arg("--crate-type=dylib")
+        .arg(format!("--crate-name={name}"))
+        .arg("--out-dir")
+        .arg(tmp_dir)
+        .arg("-")
+        .spawn()
+        .unwrap();
+
+    use std::io::Write;
+    child
+        .stdin
+        .take()
+        .unwrap()
+        .write_all(src.as_bytes())
+        .unwrap();
+    assert!(child.wait().unwrap().success());
+
+    let dynlib_path = tmp_dir.join(format!(
+        "{}{name}{}",
+        std::env::consts::DLL_PREFIX,
+        std::env::consts::DLL_SUFFIX
+    ));
+
+    crate::helper::load_module_test_with_input(
+        "tests-pl/ffi_utf8_panic.pl",
+        format!("LIB={dynlib_path:?}."),
+        // Evaluates to: 'Invalid\xFFUTF8\n'
+        "[73,110,118,97,108,105,100,255,85,84,70,56]\n",
+    );
+}